From: Andrew Morton WARNING: line over 80 characters #157: FILE: drivers/gpio/bt8xxgpio.c:7: + Please do _only_ contact the people listed _above_ with issues related to this driver. WARNING: line over 80 characters #158: FILE: drivers/gpio/bt8xxgpio.c:8: + All the other people listed below are not related to this driver. Their names WARNING: Use #include instead of #199: FILE: drivers/gpio/bt8xxgpio.c:49: +#include ERROR: space required after that ',' (ctx:VxV) #221: FILE: drivers/gpio/bt8xxgpio.c:71: +#define bgwrite(dat,adr) writel((dat), bg->mmio+(adr)) ^ WARNING: line over 80 characters #227: FILE: drivers/gpio/bt8xxgpio.c:77: +MODULE_PARM_DESC(gpiobase, "The GPIO number base. -1 means dynamic, which is the default."); ERROR: space required after that ',' (ctx:VxV) #403: FILE: drivers/gpio/bt8xxgpio.c:253: + release_mem_region(pci_resource_start(pdev,0), ^ ERROR: space required after that ',' (ctx:VxV) #404: FILE: drivers/gpio/bt8xxgpio.c:254: + pci_resource_len(pdev,0)); ^ total: 3 errors, 4 warnings, 453 lines checked ./patches/gpio-add-bt8xxgpio-driver.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: David Brownell Cc: Mauro Carvalho Chehab Cc: Michael Buesch Cc: Stephen Rothwell Signed-off-by: Andrew Morton --- drivers/gpio/bt8xxgpio.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN Documentation/bt8xxgpio.txt~gpio-add-bt8xxgpio-driver-checkpatch-fixes Documentation/bt8xxgpio.txt diff -puN MAINTAINERS~gpio-add-bt8xxgpio-driver-checkpatch-fixes MAINTAINERS diff -puN drivers/gpio/Kconfig~gpio-add-bt8xxgpio-driver-checkpatch-fixes drivers/gpio/Kconfig diff -puN drivers/gpio/Makefile~gpio-add-bt8xxgpio-driver-checkpatch-fixes drivers/gpio/Makefile diff -puN drivers/gpio/bt8xxgpio.c~gpio-add-bt8xxgpio-driver-checkpatch-fixes drivers/gpio/bt8xxgpio.c --- a/drivers/gpio/bt8xxgpio.c~gpio-add-bt8xxgpio-driver-checkpatch-fixes +++ a/drivers/gpio/bt8xxgpio.c @@ -46,7 +46,7 @@ #include #include #include -#include +#include /* Steal the hardware definitions from the bttv driver. */ #include "../media/video/bt8xx/bt848.h" @@ -68,8 +68,8 @@ struct bt8xxgpio { #endif }; -#define bgwrite(dat,adr) writel((dat), bg->mmio+(adr)) -#define bgread(adr) readl(bg->mmio+(adr)) +#define bgwrite(dat, adr) writel((dat), bg->mmio+(adr)) +#define bgread(adr) readl(bg->mmio+(adr)) static int modparam_gpiobase = -1/* dynamic */; @@ -250,8 +250,8 @@ static void bt8xxgpio_remove(struct pci_ bgwrite(0x0, BT848_GPIO_OUT_EN); iounmap(bg->mmio); - release_mem_region(pci_resource_start(pdev,0), - pci_resource_len(pdev,0)); + release_mem_region(pci_resource_start(pdev, 0), + pci_resource_len(pdev, 0)); pci_disable_device(pdev); pci_set_drvdata(pdev, NULL); _