From: Andrew Morton - remove the ifdefs using the usual pattern - make things static Cc: Bryan Wu Cc: Jeff Garzik Cc: Sonic Zhang Signed-off-by: Andrew Morton --- drivers/ata/pata_bf54x.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff -puN drivers/ata/pata_bf54x.c~libata-blackfin-pata-driver-add-proper-pm-operation-into-atapi-driver-fix drivers/ata/pata_bf54x.c --- a/drivers/ata/pata_bf54x.c~libata-blackfin-pata-driver-add-proper-pm-operation-into-atapi-driver-fix +++ a/drivers/ata/pata_bf54x.c @@ -1658,7 +1658,7 @@ static int __devexit bfin_atapi_remove(s } #ifdef CONFIG_PM -int bfin_atapi_suspend(struct platform_device *pdev, pm_message_t state) +static int bfin_atapi_suspend(struct platform_device *pdev, pm_message_t state) { struct ata_host *host = dev_get_drvdata(&pdev->dev); if (host) @@ -1667,7 +1667,7 @@ int bfin_atapi_suspend(struct platform_d return 0; } -int bfin_atapi_resume(struct platform_device *pdev) +static int bfin_atapi_resume(struct platform_device *pdev) { struct ata_host *host = dev_get_drvdata(&pdev->dev); int ret; @@ -1683,15 +1683,16 @@ int bfin_atapi_resume(struct platform_de return 0; } +#else +#define bfin_atapi_suspend NULL +#define bfin_atapi_resume NULL #endif static struct platform_driver bfin_atapi_driver = { .probe = bfin_atapi_probe, .remove = __devexit_p(bfin_atapi_remove), -#ifdef CONFIG_PM .suspend = bfin_atapi_suspend, .resume = bfin_atapi_resume, -#endif .driver = { .name = DRV_NAME, .owner = THIS_MODULE, _