From: David Brownell Remove NOP methods from rtc-pl030 and rtc-pl031 drivers; this is pure wasted code. Signed-off-by: David Brownell Cc: Alessandro Zummo Signed-off-by: Andrew Morton --- drivers/rtc/rtc-pl030.c | 11 ----------- drivers/rtc/rtc-pl031.c | 14 -------------- 2 files changed, 25 deletions(-) diff -puN drivers/rtc/rtc-pl030.c~rtc-remove-some-nop-open-release-methods drivers/rtc/rtc-pl030.c --- a/drivers/rtc/rtc-pl030.c~rtc-remove-some-nop-open-release-methods +++ a/drivers/rtc/rtc-pl030.c @@ -34,15 +34,6 @@ static irqreturn_t pl030_interrupt(int i return IRQ_HANDLED; } -static int pl030_open(struct device *dev) -{ - return 0; -} - -static void pl030_release(struct device *dev) -{ -} - static int pl030_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) { return -ENOIOCTLCMD; @@ -104,8 +95,6 @@ static int pl030_set_time(struct device } static const struct rtc_class_ops pl030_ops = { - .open = pl030_open, - .release = pl030_release, .ioctl = pl030_ioctl, .read_time = pl030_read_time, .set_time = pl030_set_time, diff -puN drivers/rtc/rtc-pl031.c~rtc-remove-some-nop-open-release-methods drivers/rtc/rtc-pl031.c --- a/drivers/rtc/rtc-pl031.c~rtc-remove-some-nop-open-release-methods +++ a/drivers/rtc/rtc-pl031.c @@ -45,18 +45,6 @@ static irqreturn_t pl031_interrupt(int i return IRQ_HANDLED; } -static int pl031_open(struct device *dev) -{ - /* - * We request IRQ in pl031_probe, so nothing to do here... - */ - return 0; -} - -static void pl031_release(struct device *dev) -{ -} - static int pl031_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) { struct pl031_local *ldata = dev_get_drvdata(dev); @@ -118,8 +106,6 @@ static int pl031_set_alarm(struct device } static const struct rtc_class_ops pl031_ops = { - .open = pl031_open, - .release = pl031_release, .ioctl = pl031_ioctl, .read_time = pl031_read_time, .set_time = pl031_set_time, _