From: Andrew Morton ERROR: open brace '{' following function declarations go on the next line #222: FILE: drivers/video/via/accel.c:204: +void viafb_show_hw_cursor(struct fb_info *info, int Status) { WARNING: suspect code indent for conditional statements #249: FILE: drivers/video/via/accel.c:231: + while (!(MMIO_IN32(VIA_REG_STATUS) & VIA_VR_QUEUE_BUSY) WARNING: suspect code indent for conditional statements #253: FILE: drivers/video/via/accel.c:235: + while ((MMIO_IN32(VIA_REG_STATUS) & total: 1 errors, 2 warnings, 421 lines checked ./patches/viafb-accelc-accelh.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Geert Uytterhoeven Cc: Joseph Chan Cc: Joseph Chan Cc: Krzysztof Helt Signed-off-by: Andrew Morton --- drivers/video/via/accel.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff -puN drivers/video/via/accel.c~viafb-accelc-accelh-checkpatch-fixes drivers/video/via/accel.c --- a/drivers/video/via/accel.c~viafb-accelc-accelh-checkpatch-fixes +++ a/drivers/video/via/accel.c @@ -201,7 +201,8 @@ void viafb_hw_cursor_init(void) MMIO_OUT32(VIA_REG_CURSOR_FG, 0x0); } -void viafb_show_hw_cursor(struct fb_info *info, int Status) { +void viafb_show_hw_cursor(struct fb_info *info, int Status) +{ u32 temp; u32 iga_path = ((struct viafb_par *)(info->par))->iga_path; @@ -222,20 +223,21 @@ void viafb_show_hw_cursor(struct fb_info default: temp &= 0x7FFFFFFF; } - MMIO_OUT32(VIA_REG_CURSOR_MODE, temp); } + MMIO_OUT32(VIA_REG_CURSOR_MODE, temp); +} int viafb_wait_engine_idle(void) { int loop = 0; - while (!(MMIO_IN32(VIA_REG_STATUS) & VIA_VR_QUEUE_BUSY) - && (loop++ < MAXLOOP)) - cpu_relax(); + while (!(MMIO_IN32(VIA_REG_STATUS) & VIA_VR_QUEUE_BUSY) && + (loop++ < MAXLOOP)) + cpu_relax(); while ((MMIO_IN32(VIA_REG_STATUS) & - (VIA_CMD_RGTR_BUSY | VIA_2D_ENG_BUSY | VIA_3D_ENG_BUSY)) && - (loop++ < MAXLOOP)) - cpu_relax(); + (VIA_CMD_RGTR_BUSY | VIA_2D_ENG_BUSY | VIA_3D_ENG_BUSY)) && + (loop++ < MAXLOOP)) + cpu_relax(); return loop >= MAXLOOP; } _