From: Ian Kent The function check_dev_ioctl_version() returns an error code upon fail but it isn't captured and returned in validate_dev_ioctl() as it should be. Signed-off-by: Ian Kent Signed-off-by: Jeff Moyer Signed-off-by: Andrew Morton --- fs/autofs4/dev-ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN fs/autofs4/dev-ioctl.c~autofs4-collect-version-check-return fs/autofs4/dev-ioctl.c --- a/fs/autofs4/dev-ioctl.c~autofs4-collect-version-check-return +++ a/fs/autofs4/dev-ioctl.c @@ -116,9 +116,9 @@ static inline void free_dev_ioctl(struct */ static int validate_dev_ioctl(int cmd, struct autofs_dev_ioctl *param) { - int err = -EINVAL; + int err; - if (check_dev_ioctl_version(cmd, param)) { + if ((err = check_dev_ioctl_version(cmd, param))) { AUTOFS_WARN("invalid device control module version " "supplied for cmd(0x%08x)", cmd); goto out; _