From: Andrew Morton ERROR: spaces required around that ':' (ctx:VxW) #75: FILE: mm/shmem.c:165: + security_vm_enough_memory_kern(VM_ACCT(size)): 0; ^ ERROR: spaces required around that ':' (ctx:VxW) #84: FILE: mm/shmem.c:183: + 0: security_vm_enough_memory_kern(VM_ACCT(PAGE_CACHE_SIZE)); ^ WARNING: labels should not be indented #84: FILE: mm/shmem.c:183: + 0: security_vm_enough_memory_kern(VM_ACCT(PAGE_CACHE_SIZE)); total: 2 errors, 1 warnings, 64 lines checked ./patches/nfsd-fix-vm-overcommit-crash.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alan Cox Cc: James Morris Cc: Junjiro R. Okajima Signed-off-by: Andrew Morton --- mm/shmem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN mm/shmem.c~nfsd-fix-vm-overcommit-crash-checkpatch-fixes mm/shmem.c --- a/mm/shmem.c~nfsd-fix-vm-overcommit-crash-checkpatch-fixes +++ a/mm/shmem.c @@ -161,8 +161,8 @@ static inline struct shmem_sb_info *SHME */ static inline int shmem_acct_size(unsigned long flags, loff_t size) { - return (flags & VM_ACCOUNT)? - security_vm_enough_memory_kern(VM_ACCT(size)): 0; + return (flags & VM_ACCOUNT) ? + security_vm_enough_memory_kern(VM_ACCT(size)) : 0; } static inline void shmem_unacct_size(unsigned long flags, loff_t size) @@ -179,8 +179,8 @@ static inline void shmem_unacct_size(uns */ static inline int shmem_acct_block(unsigned long flags) { - return (flags & VM_ACCOUNT)? - 0: security_vm_enough_memory_kern(VM_ACCT(PAGE_CACHE_SIZE)); + return (flags & VM_ACCOUNT) ? + 0 : security_vm_enough_memory_kern(VM_ACCT(PAGE_CACHE_SIZE)); } static inline void shmem_unacct_blocks(unsigned long flags, long pages) _