Subject: spufs: fix read/write on cntl From: "Noguchi, Masato" After applying these patches, it seems the kernel leaks memory. No doubt you forget to call simple_attr_close on "[PATCH 09/14] spufs: add support for read/write oncntl". Signed-off-by: Masato Noguchi Signed-off-by: Arnd Bergmann --- Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c =================================================================== --- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c +++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c @@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode static struct file_operations spufs_cntl_fops = { .open = spufs_cntl_open, + .release = simple_attr_close, .read = simple_attr_read, .write = simple_attr_write, .mmap = spufs_cntl_mmap,