Subject: spidernet: Revert 808999c9a4749dc67c39bf52f712d0c27aa00e67 This one caused bugs during testing, not yet clear why. The original commit message was: | Author: Linas Vepstas | Date: Tue Oct 10 16:01:00 2006 -0500 | | [PATCH] powerpc/cell spidernet zlen min packet length | | Polite device drivers pad short packets to 60 bytes, | so that mean-spirited users don't accidentally DOS | some other OS that can't handle short packets. | | Signed-off-by: Linas Vepstas | Cc: James K Lewis | Cc: Arnd Bergmann | Signed-off-by: Jeff Garzik --- drivers/net/spider_net.c | 17 ++++------------- drivers/net/spider_net.h | 2 +- 2 files changed, 5 insertions(+), 14 deletions(-) Index: linux-2.6/drivers/net/spider_net.c =================================================================== --- linux-2.6.orig/drivers/net/spider_net.c +++ linux-2.6/drivers/net/spider_net.c @@ -609,20 +609,12 @@ spider_net_prepare_tx_descr(struct spide struct spider_net_descr *descr; dma_addr_t buf; unsigned long flags; - int length; - length = skb->len; - if (length < ETH_ZLEN) { - if (skb_pad(skb, ETH_ZLEN-length)) - return 0; - length = ETH_ZLEN; - } - - buf = pci_map_single(card->pdev, skb->data, length, PCI_DMA_TODEVICE); + buf = pci_map_single(card->pdev, skb->data, skb->len, PCI_DMA_TODEVICE); if (pci_dma_mapping_error(buf)) { if (netif_msg_tx_err(card) && net_ratelimit()) pr_err("could not iommu-map packet (%p, %i). " - "Dropping packet\n", skb->data, length); + "Dropping packet\n", skb->data, skb->len); card->spider_stats.tx_iommu_map_error++; return -ENOMEM; } @@ -632,7 +624,7 @@ spider_net_prepare_tx_descr(struct spide card->tx_chain.head = descr->next; descr->buf_addr = buf; - descr->buf_size = length; + descr->buf_size = skb->len; descr->next_descr_addr = 0; descr->skb = skb; descr->data_status = 0; @@ -767,8 +759,7 @@ spider_net_release_tx_chain(struct spide /* unmap the skb */ if (skb) { - int len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len; - pci_unmap_single(card->pdev, buf_addr, len, PCI_DMA_TODEVICE); + pci_unmap_single(card->pdev, buf_addr, skb->len, PCI_DMA_TODEVICE); dev_kfree_skb(skb); } } Index: linux-2.6/drivers/net/spider_net.h =================================================================== --- linux-2.6.orig/drivers/net/spider_net.h +++ linux-2.6/drivers/net/spider_net.h @@ -24,7 +24,7 @@ #ifndef _SPIDER_NET_H #define _SPIDER_NET_H -#define VERSION "1.1 A" +#define VERSION "1.5 A" #include "sungem_phy.h"