Subject: Don't make printk calls in an interrupt handler From: Kevin Corry Don't print log statements in the hardware-sampling interrupt handler. Making printk calls from an interrupt handler can cause problems. Remove all log messages from the Cell hardware-sampling code that can be called from an interrupt handler. Signed-off-by: Kevin Corry Signed-off-by: Carl Love Signed-off-by: Arnd Bergmann Index: linux-2.6/arch/powerpc/perfmon/perfmon_cell_hw_smpl.c =================================================================== --- linux-2.6.orig/arch/powerpc/perfmon/perfmon_cell_hw_smpl.c +++ linux-2.6/arch/powerpc/perfmon/perfmon_cell_hw_smpl.c @@ -220,9 +220,6 @@ static int handle_full_buffer(struct pfm struct pfm_context *ctx, struct pfm_event_set *set) { - PFM_DBG_ovfl("Sampling-buffer full. free bytes=%lu, count=%lu", - buf_hdr->buf_size - buf_hdr->cur_offset, buf_hdr->count); - /* Increment the number of sampling-buffer overflows. This * is important for detecting duplicate sets of samples. */ @@ -277,11 +274,8 @@ static int pfm_cell_hw_smpl_handler(void * since we check if the buffer is full after adding the new entry. */ free_bytes = hdr->buf_size - hdr->cur_offset; - if (free_bytes < PFM_CELL_HW_SMPL_MAX_ENTRY_SIZE) { - PFM_ERR("Cell HW Sampling: Buffer is full " - "before adding new entry."); + if (free_bytes < PFM_CELL_HW_SMPL_MAX_ENTRY_SIZE) return handle_full_buffer(hdr, ctx, set); - } ent = init_entry_header(hdr, set);