From fa5181bfe1c3e215e8200e4e11a14ab7d9f3437b Mon Sep 17 00:00:00 2001 From: Christoph Lameter Date: Wed, 25 Jul 2007 20:26:59 -0700 Subject: [PATCH] Fix up reclaim counters Compound pages of an arbitrary order may now be on the LRU and may be reclaimed. Adjust the counting in vmscan.c to could the number of base pages. Also change the active and inactive accounting to do the same. Signed-off-by: Christoph Lameter --- include/linux/mm_inline.h | 36 +++++++++++++++++++++++++++--------- mm/vmscan.c | 22 ++++++++++++---------- 2 files changed, 39 insertions(+), 19 deletions(-) Index: mm/include/linux/mm_inline.h =================================================================== --- mm.orig/include/linux/mm_inline.h 2007-11-16 21:16:36.000000000 -0800 +++ mm/include/linux/mm_inline.h 2007-11-28 14:15:36.882227612 -0800 @@ -2,39 +2,57 @@ static inline void add_page_to_active_list(struct zone *zone, struct page *page) { list_add(&page->lru, &zone->active_list); - __inc_zone_state(zone, NR_ACTIVE); + if (!PageHead(page)) + __inc_zone_state(zone, NR_ACTIVE); + else + __inc_zone_page_state(page, NR_ACTIVE); } static inline void add_page_to_inactive_list(struct zone *zone, struct page *page) { list_add(&page->lru, &zone->inactive_list); - __inc_zone_state(zone, NR_INACTIVE); + if (!PageHead(page)) + __inc_zone_state(zone, NR_INACTIVE); + else + __inc_zone_page_state(page, NR_INACTIVE); } static inline void del_page_from_active_list(struct zone *zone, struct page *page) { list_del(&page->lru); - __dec_zone_state(zone, NR_ACTIVE); + if (!PageHead(page)) + __dec_zone_state(zone, NR_ACTIVE); + else + __dec_zone_page_state(page, NR_ACTIVE); } static inline void del_page_from_inactive_list(struct zone *zone, struct page *page) { list_del(&page->lru); - __dec_zone_state(zone, NR_INACTIVE); + if (!PageHead(page)) + __dec_zone_state(zone, NR_INACTIVE); + else + __dec_zone_page_state(page, NR_INACTIVE); } static inline void del_page_from_lru(struct zone *zone, struct page *page) { + enum zone_stat_item counter = NR_ACTIVE; + list_del(&page->lru); - if (PageActive(page)) { + if (PageActive(page)) __ClearPageActive(page); - __dec_zone_state(zone, NR_ACTIVE); - } else { - __dec_zone_state(zone, NR_INACTIVE); - } + else + counter = NR_INACTIVE; + + if (!PageHead(page)) + __dec_zone_state(zone, counter); + else + __dec_zone_page_state(page, counter); } + Index: mm/mm/vmscan.c =================================================================== --- mm.orig/mm/vmscan.c 2007-11-28 14:09:42.897227657 -0800 +++ mm/mm/vmscan.c 2007-11-28 14:16:32.261563421 -0800 @@ -496,14 +496,14 @@ static unsigned long shrink_page_list(st VM_BUG_ON(PageActive(page)); - sc->nr_scanned++; + sc->nr_scanned += page_cache_base_pages(page); if (!sc->may_swap && page_mapped(page)) goto keep_locked; /* Double the slab pressure for mapped and swapcache pages */ if (page_mapped(page) || PageSwapCache(page)) - sc->nr_scanned++; + sc->nr_scanned += page_cache_base_pages(page); may_enter_fs = (sc->gfp_mask & __GFP_FS) || (PageSwapCache(page) && (sc->gfp_mask & __GFP_IO)); @@ -626,7 +626,7 @@ static unsigned long shrink_page_list(st free_it: unlock_page(page); - nr_reclaimed++; + nr_reclaimed += page_cache_base_pages(page); if (!pagevec_add(&freed_pvec, page)) __pagevec_release_nonlru(&freed_pvec); continue; @@ -718,22 +718,23 @@ static unsigned long isolate_lru_pages(u unsigned long nr_taken = 0; unsigned long scan; - for (scan = 0; scan < nr_to_scan && !list_empty(src); scan++) { + for (scan = 0; scan < nr_to_scan && !list_empty(src); ) { struct page *page; unsigned long pfn; unsigned long end_pfn; unsigned long page_pfn; + int pages; int zone_id; page = lru_to_page(src); prefetchw_prev_lru_page(page, src, flags); - + pages = page_cache_base_pages(page); VM_BUG_ON(!PageLRU(page)); switch (__isolate_lru_page(page, mode)) { case 0: list_move(&page->lru, dst); - nr_taken++; + nr_taken += pages; break; case -EBUSY: @@ -779,8 +780,8 @@ static unsigned long isolate_lru_pages(u switch (__isolate_lru_page(cursor_page, mode)) { case 0: list_move(&cursor_page->lru, dst); - nr_taken++; - scan++; + nr_taken += page_cache_base_pages(cursor_page); + scan += page_cache_base_pages(cursor_page); break; case -EBUSY: @@ -790,6 +791,7 @@ static unsigned long isolate_lru_pages(u break; } } + scan += pages; } *scanned = scan; @@ -1138,7 +1140,7 @@ static void shrink_active_list(unsigned list_move(&page->lru, &zone->inactive_list); mem_cgroup_move_lists(page_get_page_cgroup(page), false); - pgmoved++; + pgmoved += page_cache_base_pages(page); if (!pagevec_add(&pvec, page)) { __mod_zone_page_state(zone, NR_INACTIVE, pgmoved); spin_unlock_irq(&zone->lru_lock); @@ -1167,7 +1169,7 @@ static void shrink_active_list(unsigned VM_BUG_ON(!PageActive(page)); list_move(&page->lru, &zone->active_list); mem_cgroup_move_lists(page_get_page_cgroup(page), true); - pgmoved++; + pgmoved += page_cache_base_pages(page); if (!pagevec_add(&pvec, page)) { __mod_zone_page_state(zone, NR_ACTIVE, pgmoved); pgmoved = 0;