Subject: [PATCH] SUN3/3X Lance trivial fix From: Cyrill V. Gorcunov This patch adds checking for allocated DVMA memory and granted IRQ line. Signed-off-by: Cyrill V. Gorcunov Acked-by: Sam Creasey Index: linux-2.6/drivers/net/sun3lance.c =================================================================== --- linux-2.6.orig/drivers/net/sun3lance.c 2007-02-17 17:26:29.000000000 +0100 +++ linux-2.6/drivers/net/sun3lance.c 2007-02-17 17:26:47.000000000 +0100 @@ -336,13 +336,20 @@ /* XXX - leak? */ MEM = dvma_malloc_align(sizeof(struct lance_memory), 0x10000); + if (MEM == NULL) { + printk(KERN_WARNING "SUN3 Lance couldn't allocate DVMA memory\n"); + return 0; + } lp->iobase = (volatile unsigned short *)ioaddr; dev->base_addr = (unsigned long)ioaddr; /* informational only */ REGA(CSR0) = CSR0_STOP; - request_irq(LANCE_IRQ, lance_interrupt, IRQF_DISABLED, "SUN3 Lance", dev); + if (request_irq(LANCE_IRQ, lance_interrupt, IRQF_DISABLED, "SUN3 Lance", dev) < 0) { + printk(KERN_WARNING "SUN3 Lance unable to allocate IRQ\n"); + return 0; + } dev->irq = (unsigned short)LANCE_IRQ;