From rdunlap@xenotime.net Tue Jul 11 20:52:06 2006 Date: Tue, 11 Jul 2006 20:49:41 -0700 From: Randy Dunlap Cc: akpm , gregkh Subject: kobject: must_check fixes Message-Id: <20060711204941.a46da8bf.rdunlap@xenotime.net> From: Randy Dunlap Check all __must_check warnings in lib/kobject.c Signed-off-by: Randy Dunlap Signed-off-by: Greg Kroah-Hartman --- lib/kobject.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- gregkh-2.6.orig/lib/kobject.c +++ gregkh-2.6/lib/kobject.c @@ -407,6 +407,7 @@ static struct kobj_type dir_ktype = { struct kobject *kobject_add_dir(struct kobject *parent, const char *name) { struct kobject *k; + int ret; if (!parent) return NULL; @@ -418,7 +419,13 @@ struct kobject *kobject_add_dir(struct k k->parent = parent; k->ktype = &dir_ktype; kobject_set_name(k, name); - kobject_register(k); + ret = kobject_register(k); + if (ret < 0) { + printk(KERN_WARNING "kobject_add_dir: " + "kobject_register error: %d\n", ret); + kobject_del(k); + return NULL; + } return k; }