From cornelia.huck@de.ibm.com Tue Feb 13 22:56:48 2007 From: Cornelia Huck Date: Wed, 14 Feb 2007 07:57:47 +0100 Subject: debugfs: Remove misleading comments. To: Greg KH Cc: Peter Oberparleiter , linux-kernel@vger.kernel.org, akpm@linux-foundation.org Message-ID: <20070214075747.4b0722e5@gondolin.boeblingen.de.ibm.com> From: Cornelia Huck Just mention which error will be returned if debugfs is disabled. Callers should be able to figure out themselves what they need to check. Signed-off-by: Cornelia Huck Signed-off-by: Greg Kroah-Hartman --- fs/debugfs/inode.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) --- gregkh-2.6.orig/fs/debugfs/inode.c +++ gregkh-2.6/fs/debugfs/inode.c @@ -212,9 +212,7 @@ static int debugfs_create_by_name(const * you are responsible here.) If an error occurs, %NULL will be returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be - * returned. It is not wise to check for this value, but rather, check for - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling - * code. + * returned. */ struct dentry *debugfs_create_file(const char *name, mode_t mode, struct dentry *parent, void *data, @@ -264,9 +262,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file); * you are responsible here.) If an error occurs, %NULL will be returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be - * returned. It is not wise to check for this value, but rather, check for - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling - * code. + * returned. */ struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) { @@ -297,9 +293,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir); * returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be - * returned. It is not wise to check for this value, but rather, check for - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling - * code. + * returned. */ struct dentry *debugfs_create_symlink(const char *name, struct dentry *parent, const char *target)