From rjw@sisk.pl Thu Mar 20 16:20:16 2008 From: Alan Stern Date: Wed, 19 Mar 2008 22:35:13 +0100 Subject: PM: Fix misuse of wakeup flag accessors in serial core To: Greg KH Cc: Andrew Morton , Alan Stern , Linux-pm mailing list , Kernel development list , lenb@kernel.org Message-ID: <200803192235.14645.rjw@sisk.pl> Content-Disposition: inline From: Alan Stern This patch (as1059) fixes a mistake in the way the serial core initializes a device's wakeup settings. It should use the accessor routine instead of relying on a macro producing an lvalue. Signed-off-by: Alan Stern Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/serial/serial_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/serial/serial_core.c +++ b/drivers/serial/serial_core.c @@ -2422,7 +2422,7 @@ int uart_add_one_port(struct uart_driver */ tty_dev = tty_register_device(drv->tty_driver, port->line, port->dev); if (likely(!IS_ERR(tty_dev))) { - device_can_wakeup(tty_dev) = 1; + device_init_wakeup(tty_dev, 1); device_set_wakeup_enable(tty_dev, 0); } else printk(KERN_ERR "Cannot register tty device on line %d\n",