From axel.lin@gmail.com Thu Jul 8 08:56:03 2010 From: Axel Lin Date: Thu, 01 Jul 2010 10:35:07 +0800 Subject: dmi-id: fix a memory leak in dmi_id_init error path To: linux-kernel Cc: Tejun Heo , David Brownell , Greg Kroah-Hartman Message-ID: <1277951707.30073.5.camel@mola> This patch adds a missing kfree(dmi_dev) in dmi_id_init error path. Signed-off-by: Axel Lin Acked-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/dmi-id.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/firmware/dmi-id.c +++ b/drivers/firmware/dmi-id.c @@ -229,10 +229,12 @@ static int __init dmi_id_init(void) ret = device_register(dmi_dev); if (ret) - goto fail_class_unregister; + goto fail_free_dmi_dev; return 0; +fail_free_dmi_dev: + kfree(dmi_dev); fail_class_unregister: class_unregister(&dmi_class);