From pcihpd-discuss-admin@lists.sourceforge.net Tue Feb 21 15:41:15 2006 From: Kristen Accardi To: Greg KH Cc: Kenji Kaneshige , Kristen Accardi Message-Id: <1140565538.24286.19.camel@whizzy> Subject: shpchp: Remove unused pci_bus member from controller structure Date: Tue, 21 Feb 2006 15:45:38 -0800 From: Kenji Kaneshige This patch removes unused 'pci_bus' member from controller structure. This patch have no functional change. Signed-off-by: Kenji Kaneshige Signed-off-by: Kristen Carlson Accardi Signed-off-by: Greg Kroah-Hartman --- drivers/pci/hotplug/shpchp.h | 1 - drivers/pci/hotplug/shpchp_core.c | 13 +------------ 2 files changed, 1 insertion(+), 13 deletions(-) --- gregkh-2.6.orig/drivers/pci/hotplug/shpchp.h +++ gregkh-2.6/drivers/pci/hotplug/shpchp.h @@ -85,7 +85,6 @@ struct controller { int num_slots; /* Number of slots on ctlr */ int slot_num_inc; /* 1 or -1 */ struct pci_dev *pci_dev; - struct pci_bus *pci_bus; struct event_info event_queue[10]; struct list_head slot_list; struct hpc_ops *hpc_ops; --- gregkh-2.6.orig/drivers/pci/hotplug/shpchp_core.c +++ gregkh-2.6/drivers/pci/hotplug/shpchp_core.c @@ -386,14 +386,6 @@ static int shpc_probe(struct pci_dev *pd pci_set_drvdata(pdev, ctrl); - ctrl->pci_bus = kmalloc(sizeof(*ctrl->pci_bus), GFP_KERNEL); - if (!ctrl->pci_bus) { - err("out of memory\n"); - rc = -ENOMEM; - goto err_out_unmap_mmio_region; - } - - memcpy (ctrl->pci_bus, pdev->bus, sizeof (*ctrl->pci_bus)); ctrl->bus = pdev->bus->number; ctrl->slot_bus = pdev->subordinate->number; ctrl->device = PCI_SLOT(pdev->devfn); @@ -408,7 +400,7 @@ static int shpc_probe(struct pci_dev *pd rc = get_ctlr_slot_config(ctrl); if (rc) { err(msg_initialization_err, rc); - goto err_out_free_ctrl_bus; + goto err_out_unmap_mmio_region; } first_device_num = ctrl->slot_device_offset; num_ctlr_slots = ctrl->num_slots; @@ -446,8 +438,6 @@ static int shpc_probe(struct pci_dev *pd err_out_free_ctrl_slot: cleanup_slots(ctrl); -err_out_free_ctrl_bus: - kfree(ctrl->pci_bus); err_out_unmap_mmio_region: ctrl->hpc_ops->release_ctlr(ctrl); err_out_free_ctrl: @@ -481,7 +471,6 @@ static void __exit unload_shpchpd(void) ctrl = list_entry(tmp, struct controller, ctrl_list); shpchp_remove_ctrl_files(ctrl); cleanup_slots(ctrl); - kfree (ctrl->pci_bus); ctrl->hpc_ops->release_ctlr(ctrl); kfree(ctrl); }