From kristen.c.accardi@intel.com Fri Apr 13 15:34:20 2007 From: Linas Vepstas Date: Fri, 13 Apr 2007 15:34:24 -0700 Subject: [patch 18/21] PCI: rpaphp: Ensure more pcibios_add/pcibios_remove symmetry To: gregkh@suse.de Message-ID: <20070413223420.860461498@intel.com> Content-Disposition: inline; filename=pci-rpaphp-ensure-more-pcibios_add-pcibios_remove-symmetry From: Linas Vepstas Calls to pcibios_add should be symmetric with calls to pcibios_remove. Signed-off-by: Linas Vepstas Cc: John Rose Signed-off-by: Kristen Carlson Accardi Signed-off-by: Greg Kroah-Hartman --- drivers/pci/hotplug/rpadlpar_core.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) --- a/drivers/pci/hotplug/rpadlpar_core.c +++ b/drivers/pci/hotplug/rpadlpar_core.c @@ -387,13 +387,8 @@ int dlpar_remove_pci_slot(char *drc_name __FUNCTION__, drc_name); return -EIO; } - } else { - struct pci_dev *dev, *tmp; - list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) { - eeh_remove_bus_device(dev); - pci_remove_bus_device(dev); - } - } + } else + pcibios_remove_pci_devices(bus); if (unmap_bus_range(bus)) { printk(KERN_ERR "%s: failed to unmap bus range\n",