From harvey.harrison@gmail.com Mon Oct 27 11:24:51 2008 From: Harvey Harrison Date: Tue, 21 Oct 2008 20:27:16 -0700 Subject: staging: correct dubious use of !x & y To: Greg KH Cc: LKML Message-ID: <1224646036.5768.8.camel@brick> Noticed by sparse: drivers/staging/me4000/me4000.c:1213:43: warning: dubious: !x & y drivers/staging/wlan-ng/p80211wext.c:1583:21: warning: dubious: !x & y Signed-off-by: Harvey Harrison Signed-off-by: Greg Kroah-Hartman --- drivers/staging/me4000/me4000.c | 2 +- drivers/staging/wlan-ng/p80211wext.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/me4000/me4000.c +++ b/drivers/staging/me4000/me4000.c @@ -1180,7 +1180,7 @@ static int me4000_xilinx_download(struct /* Wait until /INIT pin is set */ udelay(20); - if (!inl(info->plx_regbase + PLX_INTCSR) & 0x20) { + if (!(inl(info->plx_regbase + PLX_INTCSR) & 0x20)) { printk(KERN_ERR "%s:Can't init Xilinx\n", __func__); return -EIO; } --- a/drivers/staging/wlan-ng/p80211wext.c +++ b/drivers/staging/wlan-ng/p80211wext.c @@ -1580,7 +1580,7 @@ static int p80211wext_set_encodeext(stru if ( ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY ) { - if ( ! ext->alg & IW_ENCODE_ALG_WEP) { + if (!(ext->alg & IW_ENCODE_ALG_WEP)) { WLAN_LOG_DEBUG(1,"asked to set a non wep key :("); return -EINVAL; }