From jrm8005@gmail.com Wed Nov 12 14:35:58 2008 From: "J.R. Mauro" Date: Thu, 6 Nov 2008 20:30:03 -0500 Subject: Staging: rt2860: use standard bit-reverse function To: Greg KH Message-ID: <20081107013003.GB3353@tuxbook-pro> Make the rt2860 use standard bit-reversing functions Signed-off by: J.R. Mauro Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rt2860/common/rtmp_init.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) --- a/drivers/staging/rt2860/common/rtmp_init.c +++ b/drivers/staging/rt2860/common/rtmp_init.c @@ -39,6 +39,7 @@ */ #include "../rt_config.h" #include "firmware.h" +#include UCHAR BIT8[] = {0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80}; ULONG BIT32[] = {0x00000001, 0x00000002, 0x00000004, 0x00000008, @@ -89,20 +90,6 @@ const unsigned short ccitt_16Table[] = { #define ByteCRC16(v, crc) \ (unsigned short)((crc << 8) ^ ccitt_16Table[((crc >> 8) ^ (v)) & 255]) -unsigned char BitReverse(unsigned char x) -{ - int i; - unsigned char Temp=0; - for(i=0; ; i++) - { - if(x & 0x80) Temp |= 0x80; - if(i==7) break; - x <<= 1; - Temp >>= 1; - } - return Temp; -} - // // BBP register initialization set // @@ -2648,13 +2635,13 @@ NDIS_STATUS NICLoadFirmware( /* calculate firmware CRC */ for(i=0; i<(MAX_FIRMWARE_IMAGE_SIZE-2); i++, ptr++) - crc = ByteCRC16(BitReverse(*ptr), crc); + crc = ByteCRC16(bitrev8(*ptr), crc); /* End of for */ if ((pFirmwareImage[MAX_FIRMWARE_IMAGE_SIZE-2] != \ - (UCHAR)BitReverse((UCHAR)(crc>>8))) || + (UCHAR)bitrev8((UCHAR)(crc>>8))) || (pFirmwareImage[MAX_FIRMWARE_IMAGE_SIZE-1] != \ - (UCHAR)BitReverse((UCHAR)crc))) + (UCHAR)bitrev8((UCHAR)crc))) { /* CRC fail */ printk("%s: CRC = 0x%02x 0x%02x "