From penberg@cs.helsinki.fi Wed Oct 29 10:34:13 2008 From: Pekka J Enberg Date: Mon, 27 Oct 2008 23:29:31 +0200 (EET) Subject: Staging: w35und: usb_put_dev() is missing from wb35_disconnect() To: greg@kroah.com Cc: pavel@suse.cz, linux-kernel@vger.kernel.org Message-ID: From: Pekka Enberg The wb35_probe() function does usb_get_dev() so add a missing usb_put_dev() to the wb35_disconnect() function. Also fix error handling paths in wb35_probe() to call usb_put_dev() as well. Signed-off-by: Pekka Enberg Acked-by: Pavel Machek Signed-off-by: Greg Kroah-Hartman --- drivers/staging/winbond/linux/wbusb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/staging/winbond/linux/wbusb.c +++ b/drivers/staging/winbond/linux/wbusb.c @@ -275,6 +275,7 @@ error_free_hw: error_free_adapter: kfree(adapter); error: + usb_put_dev(udev); return err; } @@ -308,12 +309,12 @@ void packet_came(char *pRxBufferAddress, static void wb35_disconnect(struct usb_interface *intf) { - struct wb35_adapter * adapter = usb_get_intfdata(intf); - usb_set_intfdata(intf, NULL); + struct wb35_adapter *adapter = usb_get_intfdata(intf); - // Card remove WbWlanHalt(adapter); + usb_set_intfdata(intf, NULL); + usb_put_dev(interface_to_usbdev(intf)); } static struct usb_driver wb35_driver = {