From roel.kluin@gmail.com Tue Aug 25 22:16:22 2009 From: Roel Kluin Date: Tue, 25 Aug 2009 15:19:27 +0200 Subject: Staging: comedi: apci3200: fix test of ui_DelayTime range in i_APCI3200_CommandTestAnalogInput() To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andrew Morton , wfp5p@virginia.edu Message-ID: <4A93E4DF.7070801@gmail.com> For ui_DelayTime to be less than 1 and greater than 1023 is logically impossible. Signed-off-by: Roel Kluin Signed-off-by: Andrew Morton Cc: Bill Pemberton Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c @@ -2669,7 +2669,7 @@ int i_APCI3200_CommandTestAnalogInput(st err++; printk("\nThe Delay time base selection is in error\n"); } - if (ui_DelayTime < 1 && ui_DelayTime > 1023) { + if (ui_DelayTime < 1 || ui_DelayTime > 1023) { err++; printk("\nThe Delay time value is in error\n"); }