From wfp5p@virginia.edu Mon Sep 14 14:22:45 2009 From: Bill Pemberton Date: Fri, 11 Sep 2009 21:46:45 -0400 Subject: Staging: hv: remove use of internal list routines in RndisFilter To: greg@kroah.com Cc: hjanssen@microsoft.com Message-ID: <1252720006-22052-4-git-send-email-wfp5p@virginia.edu> The hv driver has it's own linked list routines. This removes them from RndisFilter.c Signed-off-by: Bill Pemberton Cc: Hank Janssen Cc: Haiyang Zhang Signed-off-by: Greg Kroah-Hartman --- drivers/staging/hv/RndisFilter.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) --- a/drivers/staging/hv/RndisFilter.c +++ b/drivers/staging/hv/RndisFilter.c @@ -47,13 +47,13 @@ struct rndis_device { atomic_t NewRequestId; spinlock_t request_lock; - LIST_ENTRY RequestList; + struct list_head RequestList; unsigned char HwMacAddr[HW_MACADDR_LEN]; }; struct rndis_request { - LIST_ENTRY ListEntry; + struct list_head ListEntry; struct osd_waitevent *WaitEvent; /* @@ -110,7 +110,7 @@ static struct rndis_device *GetRndisDevi spin_lock_init(&device->request_lock); - INITIALIZE_LIST_HEAD(&device->RequestList); + INIT_LIST_HEAD(&device->RequestList); device->State = RNDIS_DEV_UNINITIALIZED; @@ -150,7 +150,7 @@ static struct rndis_request *GetRndisReq /* Add to the request list */ spin_lock_irqsave(&Device->request_lock, flags); - INSERT_TAIL_LIST(&Device->RequestList, &request->ListEntry); + list_add_tail(&request->ListEntry, &Device->RequestList); spin_unlock_irqrestore(&Device->request_lock, flags); return request; @@ -162,7 +162,7 @@ static void PutRndisRequest(struct rndis unsigned long flags; spin_lock_irqsave(&Device->request_lock, flags); - REMOVE_ENTRY_LIST(&Request->ListEntry); + list_del(&Request->ListEntry); spin_unlock_irqrestore(&Device->request_lock, flags); kfree(Request->WaitEvent); @@ -273,8 +273,6 @@ static int RndisFilterSendRequest(struct static void RndisFilterReceiveResponse(struct rndis_device *Device, struct rndis_message *Response) { - LIST_ENTRY *anchor; - LIST_ENTRY *curr; struct rndis_request *request = NULL; bool found = false; unsigned long flags; @@ -282,10 +280,7 @@ static void RndisFilterReceiveResponse(s DPRINT_ENTER(NETVSC); spin_lock_irqsave(&Device->request_lock, flags); - ITERATE_LIST_ENTRIES(anchor, curr, &Device->RequestList) { - request = CONTAINING_RECORD(curr, struct rndis_request, - ListEntry); - + list_for_each_entry(request, &Device->RequestList, ListEntry) { /* * All request/response message contains RequestId as the 1st * field