From roel.kluin@gmail.com Tue Aug 25 22:17:15 2009 From: Roel Kluin Date: Tue, 25 Aug 2009 14:31:11 +0200 Subject: Staging: rt2860: Fix test in rt_ioctl_siwfrag() To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andrew Morton Message-ID: <4A93D98F.3010602@gmail.com> The test always evaluated to true. MIN_FRAG_THRESHOLD is defined 256, MAX_FRAG_THRESHOLD is defined 2346 Signed-off-by: Roel Kluin Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rt2860/sta_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/rt2860/sta_ioctl.c +++ b/drivers/staging/rt2860/sta_ioctl.c @@ -1369,8 +1369,8 @@ int rt_ioctl_siwfrag(struct net_device * if (frag->disabled) val = MAX_FRAG_THRESHOLD; - else if (frag->value >= MIN_FRAG_THRESHOLD || frag->value <= MAX_FRAG_THRESHOLD) - val = __cpu_to_le16(frag->value & ~0x1); /* even numbers only */ + else if (frag->value >= MIN_FRAG_THRESHOLD && frag->value <= MAX_FRAG_THRESHOLD) + val = __cpu_to_le16(frag->value & ~0x1); /* even numbers only */ else if (frag->value == 0) val = MAX_FRAG_THRESHOLD; else