From sven.eckelmann@gmx.de Mon Jun 14 15:49:49 2010 From: Sven Eckelmann Date: Sun, 6 Jun 2010 21:03:04 +0200 Subject: Staging: batman-adv: return -EFAULT on copy_to_user errors To: gregkh@suse.de, b.a.t.m.a.n@lists.open-mesh.net Cc: Dan Carpenter , Sven Eckelmann Message-ID: <1275850985-27105-2-git-send-email-sven.eckelmann@gmx.de> From: Dan Carpenter copy_to_user() returns the number of bites remaining but we want to return a negative error code here. Signed-off-by: Dan Carpenter Signed-off-by: Sven Eckelmann Signed-off-by: Greg Kroah-Hartman --- drivers/staging/batman-adv/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/batman-adv/device.c +++ b/drivers/staging/batman-adv/device.c @@ -196,7 +196,7 @@ ssize_t bat_device_read(struct file *fil kfree(device_packet); if (error) - return error; + return -EFAULT; return sizeof(struct icmp_packet); }