From bunk@stusta.de Mon Oct 9 00:34:51 2006 Date: Mon, 9 Oct 2006 01:16:32 +0200 From: Adrian Bunk To: Paul B Schroeder Cc: linux-kernel@vger.kernel.org, gregkh@suse.de, linux-usb-devel@lists.sourceforge.net Subject: USB: mos7840.c: fix a check-after-dereference Message-ID: <20061008231632.GQ6755@stusta.de> Content-Disposition: inline This patch fixes an obvious check-after-dereference spotted by the Coverity checker. Signed-off-by: Adrian Bunk Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/mos7840.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- gregkh-2.6.orig/drivers/usb/serial/mos7840.c +++ gregkh-2.6/drivers/usb/serial/mos7840.c @@ -2413,11 +2413,12 @@ static int mos7840_ioctl(struct usb_seri } mos7840_port = mos7840_get_port_private(port); - tty = mos7840_port->port->tty; if (mos7840_port == NULL) return -1; + tty = mos7840_port->port->tty; + dbg("%s - port %d, cmd = 0x%x", __FUNCTION__, port->number, cmd); switch (cmd) {