when ext4_ext_insert_extent() fails to insert new blocks we should free just allocated blocks. please, consider for review. Signed-off-by: Alex Tomas Signed-off-by: Mingming Cao Index: linux-2.6.22-rc1/fs/ext4/extents.c =================================================================== --- linux-2.6.22-rc1.orig/fs/ext4/extents.c 2007-05-18 16:32:27.000000000 -0700 +++ linux-2.6.22-rc1/fs/ext4/extents.c 2007-05-18 16:32:32.000000000 -0700 @@ -2067,8 +2067,12 @@ ext4_ext_store_pblock(&newex, newblock); newex.ee_len = cpu_to_le16(allocated); err = ext4_ext_insert_extent(handle, inode, path, &newex); - if (err) + if (err) { + /* free data blocks we just allocated */ + ext4_free_blocks(handle, inode, ext_pblock(&newex), + le16_to_cpu(newex.ee_len)); goto out2; + } if (extend_disksize && inode->i_size > EXT4_I(inode)->i_disksize) EXT4_I(inode)->i_disksize = inode->i_size;